linux-kernel - Re: [PATCH] regmap: mmio: Convert to regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2271111.AdDD0dnl0s@wuerfel>
Date:	Wed, 27 Jan 2016 16:51:11 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Mark Brown <broonie@...nel.org>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Simon Arlott <simon@...e.lp0.eu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage

On Wednesday 27 January 2016 15:34:09 Mark Brown wrote:
> ---
>  drivers/base/regmap/regmap-mmio.c | 261 ++++++++++++++++++++------------------
>  1 file changed, 140 insertions(+), 121 deletions(-)

Overall looks good to me, but one bug:

> +
> +#ifdef __64BIT
> +static void regmap_mmio_write64le(struct regmap_mmio_context *ctx,
> +				  unsigned int reg,
> +				  unsigned int val)
> +{
> +	writeq(val, ctx->regs + reg);
> +}
> +#endif

s/__64BIT/CONFIG_64BIT/

here and in one other line.

	Arnd