linux-kernel - Re: [RFC PATCH 2/3] lib/list_batch, x86: Enable list insertion/deletion batching in x86-64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160127163855.GV6357@twins.programming.kicks-ass.net>
Date:	Wed, 27 Jan 2016 17:38:55 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Waiman Long <Waiman.Long@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, Scott J Norton <scott.norton@...com>,
	Douglas Hatch <doug.hatch@...com>
Subject: Re: [RFC PATCH 2/3] lib/list_batch, x86: Enable list
 insertion/deletion batching in x86-64

On Tue, Jan 26, 2016 at 01:44:13PM -0800, Andi Kleen wrote:
> Waiman Long <Waiman.Long@....com> writes:
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 330e738..443e41d 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -42,6 +42,7 @@ config X86
> >  	select ARCH_SUPPORTS_NUMA_BALANCING	if X86_64
> >  	select ARCH_USE_BUILTIN_BSWAP
> >  	select ARCH_USE_CMPXCHG_LOCKREF		if X86_64
> > +	select ARCH_USE_LIST_BATCHING		if X86_64
> 
> I would make it unconditional. The code is simple enough
> and shouldn't have drawbacks on smaller systems.

I agree with the sentiment but would like to see a benchmark done on a
small system to verify all the same.