linux-kernel - Re: [PATCH] gpio: check first for invalid gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2016 09:24:14 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] gpio: check first for invalid gpio

On Fri, Jan 1, 2016 at 5:30 PM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> Even if an invalid gpio number is sent to gpio_to_desc() we try to find
> it in the list before checking if it is invalid. We can check it first
> so that it will save us from traversing the list incase of invalid gpio.

The motivation for having that test at the end is that being provided
an invalid GPIO number should be the exceptional case (i.e. it does
not happen unless there is an error in the client code). Thus for
valid GPIOs (the vast majority) we find an entry in the list and save
that test.

>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  drivers/gpio/gpiolib.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index ca66302..17a1cd5 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -70,6 +70,11 @@ struct gpio_desc *gpio_to_desc(unsigned gpio)
>         struct gpio_chip *chip;
>         unsigned long flags;
>
> +       if (!gpio_is_valid(gpio)) {
> +               WARN(1, "invalid GPIO %d\n", gpio);
> +               return NULL;
> +       }
> +
>         spin_lock_irqsave(&gpio_lock, flags);
>
>         list_for_each_entry(chip, &gpio_chips, list) {
> @@ -81,9 +86,6 @@ struct gpio_desc *gpio_to_desc(unsigned gpio)
>
>         spin_unlock_irqrestore(&gpio_lock, flags);
>
> -       if (!gpio_is_valid(gpio))
> -               WARN(1, "invalid GPIO %d\n", gpio);
> -
>         return NULL;
>  }
>  EXPORT_SYMBOL_GPL(gpio_to_desc);
> --
> 1.9.1
>