linux-kernel - Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2016 11:20:00 -0800
From:	Tyler Baker <tyler.baker@...aro.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Alexandre Courbot <gnurou@...il.com>, linux-pm@...r.kernel.org,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback

Hi Thierry,

On 21 January 2016 at 02:54, Thierry Reding <thierry.reding@...il.com> wrote:
> On Thu, Jan 21, 2016 at 08:52:26AM +0100, Tomeu Vizoso wrote:
>> As per the documentation of the devfreq_dev_profile.target callback, set
>> the freq argument to the new frequency before returning.
>>
>> This caused endless messages like this after recent changes in the core:
>>
>> devfreq 6000c800.actmon: Couldn't update frequency transition information.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
>> Reported-by: Tyler Baker <tyler.baker@...aro.org>
>> ---
>>  drivers/devfreq/tegra-devfreq.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>> index 848b93ee930f..fe9dce0245bf 100644
>> --- a/drivers/devfreq/tegra-devfreq.c
>> +++ b/drivers/devfreq/tegra-devfreq.c
>> @@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
>>       clk_set_min_rate(tegra->emc_clock, rate);
>>       clk_set_rate(tegra->emc_clock, 0);
>>
>> +     *freq = rate;
>> +
>>       return 0;
>>  }
>>
>
> I had noticed it recently but hadn't got around to look into it, thanks
> for fixing it.
>
> Tested-by: Thierry Reding <treding@...dia.com>
> Acked-by: Thierry Reding <treding@...dia.com>

I don't see this patch in -next yet, so I'm guess it hasn't been
applied. Any chance you could pick it up? This issue is now
manifesting in mainline, and causing ton of noise in the boot reports.

Cheers,

Tyler