linux-kernel - Re: [PATCH 1/4] mailbox: mailbox-test: Use more consistent format for calling copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 09:54:16 +0530
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kernel@...inux.com, maxime.coquelin@...com,
	dan.carpenter@...cle.com, seraphin.bonnaffe@...com
Subject: Re: [PATCH 1/4] mailbox: mailbox-test: Use more consistent format for
 calling copy_from_user()

On Thu, Jan 14, 2016 at 12:41 PM, Lee Jones <lee.jones@...aro.org> wrote:
> While we're at it, ensure copy-to location is NULL'ed in the error path.
>
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mailbox/mailbox-test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
> index 684ae17..7d9b915 100644
> --- a/drivers/mailbox/mailbox-test.c
> +++ b/drivers/mailbox/mailbox-test.c
> @@ -63,9 +63,9 @@ static ssize_t mbox_test_signal_write(struct file *filp,
>         if (!tdev->signal)
>                 return -ENOMEM;
>
> -       ret = copy_from_user(tdev->signal, userbuf, count);
> -       if (ret) {
> +       if (copy_from_user(tdev->signal, userbuf, count)) {
>                 kfree(tdev->signal);
> +               tdev->signal = NULL;
>                 return -EFAULT;
>         }
>
The function is left to return based on an uninitialized variable
('ret' on stack), so please merge this and the patch 2/4.

Thanks.