linux-kernel - Re: [PATCH V5 5/5] regulator: max77620: add regulator driver for max77620/max20024

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A9B41C.4070607@nvidia.com>
Date:	Thu, 28 Jan 2016 11:54:28 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	<robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<linus.walleij@...aro.org>, <gnurou@...il.com>,
	<lee.jones@...aro.org>, <broonie@...nel.org>,
	<a.zummo@...ertech.it>, <alexandre.belloni@...e-electrons.com>
CC:	<lgirdwood@...il.com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
	<rtc-linux@...glegroups.com>, <swarren@...dia.com>,
	<treding@...dia.com>, Mallikarjun Kasoju <mkasoju@...dia.com>
Subject: Re: [PATCH V5 5/5] regulator: max77620: add regulator driver for
 max77620/max20024


On Thursday 28 January 2016 09:25 AM, Krzysztof Kozlowski wrote:
> On 27.01.2016 23:10, Laxman Dewangan wrote:
>> MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the
>> multiple DCDC and LDOs. This supplies the power to different
>> components of the system.
>> Also these rails has configuration for ramp time, flexible
>> power sequence, slew rate etc.
>>
>> Add regulator driver to access these rails via regulator APIs.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
>> Signed-off-by: Mallikarjun Kasoju <mkasoju@...dia.com>
>> ---
>> Changes from V1:
>> - Cleanup code based on comment received on mfd/rtc.
>> - Avoid duplication on error message.
>>
>> Changes form V2:
>> - Run coccicheck and checkpatch in strict mode for the alignment.
>> - Refactor Regulator driver to use core API for DT parsing.
>> - Update based on API changes.
>>
>> Changes from V3:
>> - Change all sys initcall to module driver.
>> - change the max77620_read argument to unisgned int from u8.
>>
>> Changes from V4:
>> - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt
>> - Detail out properties.
> What does it mean "Detail out properties"? What have changed>

Based on review comment from Linus W, I added more description on the 
properties.

>
>>   .../bindings/regulator/regulator-max77620.txt      | 163 ++++
> Please put the bindings in separate patch. It might be easier for DT
> guys to review them (they are acking the bindings, not the driver). Also
OK, will push it.


> I already reviewed the patchset but because of adding bindings here, you
> could not add my reviewed-by tag (which makes my effort not tracked...).
Yaah, This patch include the dt binding and so wanted your review again. 
This si only reason to not add reviewed-by.

Now I am going to separate out DT binding and driver,  I will add 
reviewed-by tag for you in driver file.