linux-kernel - Re: [PATCH v4 07/13] ARM: at91: pm: find and remap the pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160128083822.GB20165@piout.net>
Date:	Thu, 28 Jan 2016 09:38:22 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Michael Turquette <mturquette@...libre.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-clk@...r.kernel.org
Subject: Re: [PATCH v4 07/13] ARM: at91: pm: find and remap the pmc

On 28/01/2016 at 00:33:47 -0800, Stephen Boyd wrote :
> On 01/27, Alexandre Belloni wrote:
> > @@ -399,13 +400,33 @@ static void __init at91_pm_sram_init(void)
> >  			&at91_pm_suspend_in_sram, at91_pm_suspend_in_sram_sz);
> >  }
> >  
> > +static __initconst struct of_device_id atmel_pmc_ids[] = {
> 
> The kbuild error is weird, but __initconst should come right
> before the equals sign (=). Plus it should actually be const.
> 

Yeah, I sent v5, right after v4. I had that change but forgot to squash
it.

> > +	{ .compatible = "atmel,at91rm9200-pmc"  },
> > +	{ .compatible = "atmel,at91sam9260-pmc" },
> > +	{ .compatible = "atmel,at91sam9g45-pmc" },
> > +	{ .compatible = "atmel,at91sam9n12-pmc" },
> > +	{ .compatible = "atmel,at91sam9x5-pmc" },
> > +	{ .compatible = "atmel,sama5d3-pmc" },
> > +	{ .compatible = "atmel,sama5d2-pmc" },
> > +	{ /* sentinel */ },
> > +};
> > +
> >  static void __init at91_pm_init(void)
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com