lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jan 2016 09:49:15 +0100 From: Arnd Bergmann <arnd@...db.de> To: linux-arm-kernel@...ts.infradead.org Cc: Paul Gortmaker <paul.gortmaker@...driver.com>, Rasesh Mody <rasesh.mody@...gic.com>, netdev@...r.kernel.org, Rafał Miłecki <zajec5@...il.com>, linux-kernel@...r.kernel.org, Rajesh Borundia <Rajesh.Borundia@...gic.com>, Michael Chan <mchan@...adcom.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency On Wednesday 27 January 2016 11:11:10 Paul Gortmaker wrote: > [[PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency] On 27/01/2016 (Wed 15:04) Arnd Bergmann wrote: > > > The bgmac driver depends on BCMA_HOST_SOC, which is only used > > when CONFIG_BCMA is enabled. However, it is a bool option and can > > be set when CONFIG_BCMA=m, and then bgmac can be built-in, leading > > to an obvious link error: > > > > drivers/built-in.o: In function `bgmac_init': > > :(.init.text+0x7f2c): undefined reference to `__bcma_driver_register' > > drivers/built-in.o: In function `bgmac_exit': > > :(.exit.text+0x110a): undefined reference to `bcma_driver_unregister' > > > > To avoid this case, we need to depend on both BCMA and BCMA_SOC, > > as this patch does. I'm also trying to make the dependency more > > readable by splitting it into three lines, and adding a COMPILE_TEST > > alternative so we can test-build it in all configurations that > > support BCMA. > > It wasn't immediately clear to me from the above why you added the > select on FIXED_PHY. > Right, I'll resend the patch with improved changelog. This series is mostly patches for old and rare randconfig bugs, so I had built thousands of configurations and fixed up everything until new warnings or errors kept coming up. The FIXED_PHY error came up in the same driver so I merged the two patches but did not notice how the changelog failed to explain it. Thanks, Arnd
Powered by blists - more mailing lists