linux-kernel - Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 17:48:53 +0800
From:	chenfeng <puck.chen@...ilicon.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	<linux-kernel@...r.kernel.org>, <lgirdwood@...il.com>,
	<broonie@...nel.org>, <yudongbin@...ilicon.com>,
	<saberlily.xia@...ilicon.com>, <suzhuangluan@...ilicon.com>,
	<kong.kongxinwei@...ilicon.com>, <xuyiping@...ilicon.com>,
	<z.liuxinliang@...ilicon.com>, <puck.chenfeng@...il.com>,
	<weidong2@...ilicon.com>, <w.f@...wei.com>,
	<qijiwen@...ilicon.com>, <peter.panshilin@...ilicon.com>,
	<dan.zhao@...ilicon.com>, <linuxarm@...wei.com>,
	<liguozhu@...ilicon.com>
Subject: Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver

Hi Lee,

Thanks for your review!
There is one things need your confirm.
Please help to see it below.

On 2016/1/25 22:22, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
> 
>> Add pmic mfd driver to support hisilicon hi665x.
[..]

> 
>> +static const struct mfd_cell hi655x_pmic_devs[] = {
>> +	{ .name = "hi655x-regulator", },
>> +};
> 
> What other devices are there?
> 

Current the MFD PMIC driver only has regulator enable.

The RTC & Power-key are not in these patch sets.

They will be added later.

Will this be accepted?

>> +static const struct regmap_irq hi655x_irqs[] = {
>> +	{ .reg_offset = 0, .mask = OTMP_D1R_INT },