[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdZEYw2aADQDNSi0kKns17nKZQZKY+harLhc0j3pA-5FuA@mail.gmail.com>
Date: Thu, 28 Jan 2016 11:04:10 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Laxman Dewangan <ldewangan@...dia.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Paweł Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Alexandre Courbot <gnurou@...il.com>,
Lee Jones <lee.jones@...aro.org>,
Mark Brown <broonie@...nel.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
Liam Girdwood <lgirdwood@...il.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
Stephen Warren <swarren@...dia.com>,
Thierry Reding <treding@...dia.com>,
Krzysztof Kozłowski <k.kozlowski@...sung.com>,
vreddytalla@...dia.com, Chaitanya Bandi <bandik@...dia.com>
Subject: Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024
On Tue, Jan 19, 2016 at 11:19 AM, Laxman Dewangan <ldewangan@...dia.com> wrote:
> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
> which also act as the special function in alternate mode. Also
> there is configuration like push-pull, open drain, FPS timing
> etc for these pins.
>
> Add pincontrol driver to configure these parameters through
> pincontrol APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Signed-off-by: Chaitanya Bandi <bandik@...dia.com>
Nice. This driver looks like a lot of hard work, but I think
it's worth it.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
I guess Lee will be merging this into the MTD tree.
(I still had those comments on the DT bindings but this driver
part looks fine.)
Yours,
Linus Walleij
Powered by blists - more mailing lists