linux-kernel - Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 12:31:59 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	James Liao <jamesjj.liao@...iatek.com>,
	linux-arm-kernel@...ts.infradead.org,
	kbuild test robot <lkp@...el.com>,
	srv_heupstream@...iatek.com, devicetree@...r.kernel.org,
	Mike Turquette <mturquette@...libre.com>,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	kbuild-all@...org, Sascha Hauer <kernel@...gutronix.de>,
	Matthias Brugger <matthias.bgg@...il.com>,
	linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section

On Thursday 28 January 2016 00:36:56 Stephen Boyd wrote:
> On 01/27, Arnd Bergmann wrote:
> > On Wednesday 27 January 2016 17:56:18 James Liao wrote:
> > > > 
> > > > I think you should include this change in your patch, or as a preparation.
> > > > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM,
> > > > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that
> > > > selects COMMON_CLK.
> > > 
> > > Oops, I didn't notice there are warnings after moving these Kconfigs
> > > into menu section.
> > > 
> > > The original motivation of this patch is preventing new clk drivers
> > > include their Kconfig in a wrong place, so it's not critical. Do you
> > > think we should apply this patch (with your changes below) or drop this
> > > patch directly?
> > 
> > 
> > I think your patch is good, we just need to fix S3C24xx, which is doing
> > things in a strange way for historic reasons.
> 
> So far we've taken the approach of not caring if they include
> their Kconfig outside the common clk menu when all the configs
> inside the Kconfig file are hidden. Of course, when they aren't
> hidden this becomes a problem, but that isn't the case unless
> something changed recently.

They are all hidden, but there is no real reason for that I think
(other than the samsung glitch).

Having them inside the menu makes it possible to add '|| COMPILE_TEST'
as a follow-up, and makes it more consistent overall.

	Arnd