linux-kernel - Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 11:34:40 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Mel Gorman <mgorman@...hsingularity.net>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Mike Galbraith <mgalbraith@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: Make schedstats a runtime tunable that is
 disabled by default v2

On Thu, 28 Jan, at 10:59:25AM, Mel Gorman wrote:
> 
> It wasn't really. The patch increased the function size by enough that
> I uninlined it and let the compiler make the decision. In this case,
> it should automatically inline but I can leave the inline in.

Letting the compiler make the decision seems fine to me, but I'll let
other people chime in with their 'static inline' opinions.

My concern was that you didn't intend to delete the keyword, and it
was done by accident. But since that's not the case, it's no big deal.