linux-kernel - Re: [PATCH] drm/amdgpu: fix non-ANSI declaration of amdgpu_amdkfd_gfx_*_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 14:00:27 +0200
From:	Oded Gabbay <oded.gabbay@...il.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Dave Airlie <airlied@...hat.com>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: fix non-ANSI declaration of amdgpu_amdkfd_gfx_*_get_functions()

On Fri, Jan 22, 2016 at 7:35 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> amdgpu_amdkfd_gfx_7_get_functions and amdgpu_amdkfd_gfx_8_0_get_functions
> have no parameters, so use the normal void parameter convention to make
> them  match their prototypes in the header file
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
> index 0e13763..362bedc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c
> @@ -154,7 +154,7 @@ static const struct kfd2kgd_calls kfd2kgd = {
>         .get_fw_version = get_fw_version
>  };
>
> -struct kfd2kgd_calls *amdgpu_amdkfd_gfx_7_get_functions()
> +struct kfd2kgd_calls *amdgpu_amdkfd_gfx_7_get_functions(void)
>  {
>         return (struct kfd2kgd_calls *)&kfd2kgd;
>  }
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> index 79fa5c7..04b744d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> @@ -115,7 +115,7 @@ static const struct kfd2kgd_calls kfd2kgd = {
>         .get_fw_version = get_fw_version
>  };
>
> -struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions()
> +struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions(void)
>  {
>         return (struct kfd2kgd_calls *)&kfd2kgd;
>  }
> --
> 2.7.0.rc3
>

Thanks,
Applied to my -next tree

Oded