linux-kernel - Re: [PATCH] net/mac80211/agg-rx.c: fix use of uninitialised values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160128123022.GB13219@mwanda>
Date:	Thu, 28 Jan 2016 15:30:22 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Julian Calaby <julian.calaby@...il.com>
Cc:	Chris Bainbridge <chris.bainbridge@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Johannes Berg <johannes@...solutions.net>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	aryabinin@...tuozzo.com, Julia Lawall <Julia.Lawall@...6.fr>,
	kernel-janitors@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] net/mac80211/agg-rx.c: fix use of uninitialised values

It's not the return where we should trigger the warning it's at the

	rcu_assign_pointer(sta->ampdu_mlme.tid_rx[tid], tid_agg_rx);

line.  That's for correctness, but also it should be slightly easier.
Or it should cut down on false positives if we ignored returns and only
looked global scope type assignements.

regards,
dan carpenter