linux-kernel - Re: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 16:00:13 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	<linux-arm-kernel@...ts.infradead.org>, <broonie@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	Cyrille Pitchen <cyrille.pitchen@...el.com>,
	Wenyou Yang <wenyou.yang@...el.com>,
	<linux-spi@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform

Nicolas Ferre <nicolas.ferre@...el.com> writes:

> From: Cyrille Pitchen <cyrille.pitchen@...el.com>
>
> The non-DT platform that uses this driver (actually the AVR32) was taking a bad
> branch for determining if the IP would use gpio for CS.
> Adding the presence of DT as a condition fixes this issue.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@...el.com>
> [nicolas.ferre@...el.com: extract from ml discussion]
> Reported-by: Mans Rullgard <mans@...sr.com>
> Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
> Cc: <stable@...r.kernel.org> # 4.2+
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>

Tested-by: Mans Rullgard <mans@...sr.com>

> ---
>  drivers/spi/spi-atmel.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index aebad36391c9..8feac599e9ab 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
>
>  	as->use_cs_gpios = true;
>  	if (atmel_spi_is_v2(as) &&
> +	    pdev->dev.of_node &&
>  	    !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
>  		as->use_cs_gpios = false;
>  		master->num_chipselect = 4;
> -- 
> 2.1.3
>

-- 
Måns Rullgård