linux-kernel - Re: [PATCH 4/5] HSI: ssi-protocol: Use handshake logic from n950

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160128165415.GC17038@earth>
Date:	Thu, 28 Jan 2016 17:54:16 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Tony Lindgren <tony@...mide.com>,
	Benoît Cousson <bcousson@...libre.com>,
	Paul Walmsley <paul@...an.com>,
	Aaro Koskinen <aaro.koskinen@....fi>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] HSI: ssi-protocol: Use handshake logic from n950

Hi,

On Sun, Jan 17, 2016 at 04:49:08PM +0100, Sebastian Reichel wrote:
> When using the ssi-protocol driver with the Nokia N950, the
> following error is thrown during modem powered up sequence.
> 
> [13852.274993]  port0: SSI error: 0x01
> [13852.279205] ssi-protocol ssi-protocol: RX error detected
> [13852.284820] ssi-protocol ssi-protocol: Main state: 1
> [13852.290069] ssi-protocol ssi-protocol: Recv state: 0
> [13852.295288] ssi-protocol ssi-protocol: Send state: 0
> [13852.300537] ssi-protocol ssi-protocol: CMT Offline
> [13852.305603] ssi-protocol ssi-protocol: Wake test 1
> [13852.310638] ssi-protocol ssi-protocol: Data RX id: 0
> [13852.315887] ssi-protocol ssi-protocol: Data TX id: 0
> [13856.001464] ssi-protocol ssi-protocol: Watchdog trigerred
> [13856.007293] ssi-protocol ssi-protocol: Main state: 1
> [13856.012542] ssi-protocol ssi-protocol: Recv state: 0
> [13856.017761] ssi-protocol ssi-protocol: Send state: 0
> [13856.023010] ssi-protocol ssi-protocol: CMT Offline
> [13856.028045] ssi-protocol ssi-protocol: Wake test 0
> [13856.033111] ssi-protocol ssi-protocol: Data RX id: 0
> [13856.038330] ssi-protocol ssi-protocol: Data TX id: 0
> 
> This patch fixes the issue by using the handshake setup from
> the Nokia N950 kernel. The new handshake sequence also works
> with the N900, so there is no need to differentiate between
> both modems.

I queued this patch with Aaro's Tested-By:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=87d99063be016ceee90723a13365a40b21eec0d9

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)