linux-kernel - Re: [PATCH 08/31] media: v4l-core add v4l_enable/disable_media

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56AA4BEC.8080807@osg.samsung.com>
Date:	Thu, 28 Jan 2016 10:12:12 -0700
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	tiwai@...e.com, clemens@...isch.de, hans.verkuil@...co.com,
	laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
	javier@....samsung.com, pawel@...iak.com, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, perex@...ex.cz, arnd@...db.de,
	dan.carpenter@...cle.com, tvboxspy@...il.com, crope@....fi,
	ruchandani.tina@...il.com, corbet@....net, chehabrafael@...il.com,
	k.kozlowski@...sung.com, stefanr@...6.in-berlin.de,
	inki.dae@...sung.com, jh1009.sung@...sung.com,
	elfring@...rs.sourceforge.net, prabhakar.csengg@...il.com,
	sw0312.kim@...sung.com, p.zabel@...gutronix.de,
	ricardo.ribalda@...il.com, labbott@...oraproject.org,
	pierre-louis.bossart@...ux.intel.com, ricard.wanderlof@...s.com,
	julian@...st.de, takamichiho@...il.com, dominic.sacre@....de,
	misterpib@...il.com, daniel@...que.org, gtmkramer@...all.nl,
	normalperson@...t.net, joe@...po.co.uk, linuxbugs@...tgam.net,
	johan@...ud.se, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-api@...r.kernel.org,
	alsa-devel@...a-project.org, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 08/31] media: v4l-core add
 v4l_enable/disable_media_tuner() helper functions

On 01/28/2016 08:26 AM, Mauro Carvalho Chehab wrote:
> Em Wed,  6 Jan 2016 13:26:57 -0700
> Shuah Khan <shuahkh@....samsung.com> escreveu:
> 
>> Add a new interfaces to be used by v4l-core to invoke enable
>> source and disable_source handlers in the media_device. The
>> enable_source helper function invokes the enable_source handler
>> to find tuner entity connected to the decoder and check is it
>> is available or busy. If tuner is available, link is activated
>> and pipeline is started. The disable_source helper function
>> invokes the disable_source handler to deactivate and stop the
>> pipeline.
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  drivers/media/v4l2-core/v4l2-dev.c | 27 +++++++++++++++++++++++++++
>>  include/media/v4l2-dev.h           |  4 ++++
>>  2 files changed, 31 insertions(+)
>>
>> diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/drivers/media/v4l2-core/v4l2-dev.c
>> index d8e5994..f06da6e 100644
>> --- a/drivers/media/v4l2-core/v4l2-dev.c
>> +++ b/drivers/media/v4l2-core/v4l2-dev.c
>> @@ -233,6 +233,33 @@ struct video_device *video_devdata(struct file *file)
>>  }
>>  EXPORT_SYMBOL(video_devdata);
>>  
>> +int v4l_enable_media_tuner(struct video_device *vdev)
> 
> IMHO, the better is to put those MC ancillary routines on a separate file.
> Hans suggested to add them at v4l2-mc.h and v4l2-mc.h.

ok I can do that.

> 
>> +{
>> +#ifdef CONFIG_MEDIA_CONTROLLER
>> +	struct media_device *mdev = vdev->entity.graph_obj.mdev;
>> +	int ret;
>> +
>> +	if (!mdev || !mdev->enable_source)
>> +		return 0;
>> +	ret = mdev->enable_source(&vdev->entity, &vdev->pipe);
>> +	if (ret)
>> +		return -EBUSY;
>> +	return 0;
>> +#endif /* CONFIG_MEDIA_CONTROLLER */
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(v4l_enable_media_tuner);
>> +
>> +void v4l_disable_media_tuner(struct video_device *vdev)
>> +{
>> +#ifdef CONFIG_MEDIA_CONTROLLER
>> +	struct media_device *mdev = vdev->entity.graph_obj.mdev;
>> +
>> +	if (mdev && mdev->disable_source)
>> +		mdev->disable_source(&vdev->entity);
>> +#endif /* CONFIG_MEDIA_CONTROLLER */
>> +}
>> +EXPORT_SYMBOL_GPL(v4l_disable_media_tuner);
>>  
>>  /* Priority handling */
>>  
>> diff --git a/include/media/v4l2-dev.h b/include/media/v4l2-dev.h
>> index eeabf20..68999a3 100644
>> --- a/include/media/v4l2-dev.h
>> +++ b/include/media/v4l2-dev.h
>> @@ -87,6 +87,7 @@ struct video_device
>>  #if defined(CONFIG_MEDIA_CONTROLLER)
>>  	struct media_entity entity;
>>  	struct media_intf_devnode *intf_devnode;
>> +	struct media_pipeline pipe;
>>  #endif
>>  	/* device ops */
>>  	const struct v4l2_file_operations *fops;
>> @@ -176,6 +177,9 @@ void video_unregister_device(struct video_device *vdev);
>>     latter can also be used for video_device->release(). */
>>  struct video_device * __must_check video_device_alloc(void);
>>  
>> +int v4l_enable_media_tuner(struct video_device *vdev);
>> +void v4l_disable_media_tuner(struct video_device *vdev);
> 
> Documentation?

Since I am going to be adding a new source file, I can
add documentation in the same patch.

thanks,
-- Shuah

> 
>> +
>>  /* this release function frees the vdev pointer */
>>  void video_device_release(struct video_device *vdev);
>>  


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978