[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56AA4CAB.6000708@arm.com>
Date: Thu, 28 Jan 2016 17:15:23 +0000
From: Robin Murphy <robin.murphy@....com>
To: Anup Patel <anup.patel@...adcom.com>,
Catalin Marinas <catalin.marinas@....com>,
Joerg Roedel <joro@...tes.org>,
Will Deacon <will.deacon@....com>,
Robin Murphy <Robin.Murphy@....com>,
Sricharan R <sricharan@...eaurora.org>,
Linux IOMMU <iommu@...ts.linux-foundation.org>,
Linux ARM Kernel <linux-arm-kernel@...ts.infradead.org>
Cc: Mark Rutland <mark.rutland@....com>,
Device Tree <devicetree@...r.kernel.org>,
Scott Branden <sbranden@...adcom.com>,
Pawel Moll <pawel.moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Ray Jui <rjui@...adcom.com>,
Linux Kernel <linux-kernel@...r.kernel.org>,
Vikram Prakash <vikramp@...adcom.com>,
Rob Herring <robh+dt@...nel.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
Kumar Gala <galak@...eaurora.org>
Subject: Re: [RFC PATCH 3/6] of: iommu: Increment DT node refcount in
of_iommu_set_ops()
On 27/01/16 05:21, Anup Patel wrote:
> We are saving pointer to iommu DT node in of_iommu_set_ops()
> hence we should increment DT node ref count.
Oh man, shame on whoever wrote that code! :P
Reviewed-by: Robin Murphy <robin.murphy@....com>
> Signed-off-by: Anup Patel <anup.patel@...adcom.com>
> Reviewed-by: Ray Jui <rjui@...adcom.com>
> Reviewed-by: Scott Branden <sbranden@...adcom.com>
> ---
> drivers/iommu/of_iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
> index 60ba238..5fea665 100644
> --- a/drivers/iommu/of_iommu.c
> +++ b/drivers/iommu/of_iommu.c
> @@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct iommu_ops *ops)
> if (WARN_ON(!iommu))
> return;
>
> + of_node_get(np);
> INIT_LIST_HEAD(&iommu->list);
> iommu->np = np;
> iommu->ops = ops;
>
Powered by blists - more mailing lists