linux-kernel - Re: [PATCH v1 1/1] tools/perf: try to make output directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160128184922.GA6170@kernel.org>
Date:	Thu, 28 Jan 2016 15:49:22 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	"Hunter, Adrian" <adrian.hunter@...el.com>
Subject: Re: [PATCH v1 1/1] tools/perf: try to make output directory

Em Thu, Jan 28, 2016 at 08:41:52PM +0200, Andy Shevchenko escreveu:
> Instead of just complaining and fail try to create output directory fisrt like
> it's done in main Linux kernel Makefile.

That was intentionally disabled, please look at the changelog.

- Arnaldo
 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  tools/build/Makefile | 2 +-
>  tools/perf/Makefile  | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/build/Makefile b/tools/build/Makefile
> index 0d5a0e3..3f60b67 100644
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile
> @@ -3,7 +3,7 @@ srctree := $(patsubst %/,%,$(dir $(shell pwd)))
>  srctree := $(patsubst %/,%,$(dir $(srctree)))
>  endif
>  
> -include $(srctree)/tools//scripts/Makefile.include
> +include $(srctree)/tools/scripts/Makefile.include
>  
>  define allow-override
>    $(if $(or $(findstring environment,$(origin $(1))),\
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index dcd9a70..4e68eba 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -35,6 +35,9 @@ endif
>  #
>  ifneq ($(O),)
>    FULL_O := $(shell readlink -f $(O) || echo $(O))
> +  saved-output := $(FULL_O)
> +  FULL_O := $(shell mkdir -p $(FULL_O) && cd $(FULL_O) && /bin/pwd)
> +  $(if $(FULL_O),, $(error failed to create output directory "$(saved-output)"))
>  endif
>  
>  #
> -- 
> 2.7.0.rc3