linux-kernel - RE: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0301MB1654D5EDF0A489A1E212BF6AA0DA0@BY2PR0301MB1654.namprd03.prod.outlook.com>
Date:	Thu, 28 Jan 2016 19:07:28 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Olaf Hering <olaf@...fle.de>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"ohering@...e.com" <ohering@...e.com>,
	"jbottomley@...allels.com" <jbottomley@...allels.com>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"apw@...onical.com" <apw@...onical.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"hare@...e.de" <hare@...e.de>
Subject: RE: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild
 test robot



> -----Original Message-----
> From: Olaf Hering [mailto:olaf@...fle.de]
> Sent: Thursday, January 28, 2016 7:56 AM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; ohering@...e.com;
> jbottomley@...allels.com; hch@...radead.org; linux-scsi@...r.kernel.org;
> apw@...onical.com; vkuznets@...hat.com; jasowang@...hat.com;
> martin.petersen@...cle.com; hare@...e.de
> Subject: Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test
> robot
> 
> On Wed, Jan 27, K. Y. Srinivasan wrote:
> 
> > +	depends on SCSI_FC_ATTRS
> 
> I think 'depends' instead of 'select' will cause HYPERV_STORAGE to
> disapepar during make oldconfig if SCSI_FC_ATTRS was not set before.
> Not sure what the policy of 'depends' vs.  'select' actually is.  If
> SCSI_FC_ATTRS is supposed to be a library kind of thing then 'select'
> might be the correct way.

The current build issue is because the Hyper-V storage is configured to be built with
the kernel while the SCSI_FC_AATRS is configured as a module. This patch fixes that issue.
I too am not sure what the policy of using "depends" vs " select" is.
James, what would be your recommendation here.

Regards,

K. Y
> 
> Olaf