linux-kernel - Re: Move wlan-ng out of staging?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Jan 2016 11:56:04 +1100
From:	Julian Calaby <julian.calaby@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Ksenija Stanojević <ksenija.stanojevic@...il.com>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kalle Valo <kvalo@...eaurora.org>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: Move wlan-ng out of staging?

Hi Greg,

On Thu, Jan 28, 2016 at 10:32 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Thu, Jan 28, 2016 at 10:28:38AM +1100, Julian Calaby wrote:
>> Hi Greg,
>>
>> On Thu, Jan 28, 2016 at 10:07 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
>> > On Thu, Jan 28, 2016 at 09:48:16AM +1100, Julian Calaby wrote:
>> >> Hi Glen,
>> >>
>> >> On Thu, Jan 28, 2016 at 5:27 AM, Kalle Valo <kvalo@...eaurora.org> wrote:
>> >> > Dan Carpenter <dan.carpenter@...cle.com> writes:
>> >> >
>> >> >> On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote:
>> >> >>> Hi All,
>> >> >>>
>> >> >>> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
>> >> >>> wlan-ng driver is maybe ready to be moved out of staging. Are there
>> >> >>> any TODO tasks left to do beside checkpatch.pl clean-up?
>> >> >
>> >> > For questions like this you should CC linux-wireless.
>> >> >
>> >> >> I happened to look through this code recently.  It's terrible.
>> >> >
>> >> > And uses wireless extensions, yuck. There's a lot of work to get it into
>> >> > reasonable shape, fixing checkpatch warnings will not be enough.
>> >>
>> >> On the same subject, the wilc1000 driver has taken some pretty big
>> >> steps in the past few days, how far away do you think it is from
>> >> graduating from staging?
>> >
>> > I have 221 patches in my to-apply queue to be merged for this driver, at
>> > the very least, those need to be merged before anyone should review it
>> > for graduation.  That number also implies that there is still quite a
>> > lot to be done, but I would not know for sure until that happens.
>>
>> I figured that was the case (there's a _lot_ of churn on that driver)
>> however I've noticed the patches recently have swung away from being
>> straight checkpatch / coding style cleanups towards feature additions
>> and bug fixes, hence my question.
>
> Please feel free to audit it and let us know the details :)

After looking at the latest round of patches, I take back my comment:
it's not ready.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/