lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <56AADA02.9040900@gmail.com>
Date:	Fri, 29 Jan 2016 13:18:26 +1000
From:	Ben Skeggs <skeggsb@...il.com>
To:	Insu Yun <wuninsu@...il.com>, Ilia Mirkin <imirkin@...m.mit.edu>
Cc:	David Airlie <airlied@...ux.ie>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Ville Syrjälä <ville.syrjala@...ux.intel.com>,
	maarten.lankhorst@...ux.intel.com,
	Thierry Reding <treding@...dia.com>,
	Alexandre Courbot <acourbot@...dia.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Taesoo Kim <taesoo@...ech.edu>,
	Yeongjin Jang <yeongjin.jang@...ech.edu>,
	"Yun, Insu" <insu@...ech.edu>, Changwoo Min <changwoo@...ech.edu>
Subject: Re: [PATCH] nouveau: need to handle failed allocation

On 01/29/2016 10:12 AM, Insu Yun wrote:
> 
> On Thu, Jan 28, 2016 at 7:08 PM, Ilia Mirkin <imirkin@...m.mit.edu
> <mailto:imirkin@...m.mit.edu>> wrote:
> 
>     On Thu, Jan 28, 2016 at 7:09 PM, Insu Yun <wuninsu@...il.com
>     <mailto:wuninsu@...il.com>> wrote:
>     > drm_property_create_range can be failed in memory pressure.
>     > So, it needs to be handled.
>     >
>     > Signed-off-by: Insu Yun <wuninsu@...il.com <mailto:wuninsu@...il.com>>
>     > ---
>     >  drivers/gpu/drm/nouveau/nouveau_display.c | 6 ++++++
>     >  1 file changed, 6 insertions(+)
>     >
>     > diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
>     > index 24be27d..26b4902 100644
>     > --- a/drivers/gpu/drm/nouveau/nouveau_display.c
>     > +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
>     > @@ -443,6 +443,12 @@ nouveau_display_create_properties(struct drm_device *dev)
>     >         /* -100..+100 */
>     >         disp->color_vibrance_property =
>     >                 drm_property_create_range(dev, 0, "color vibrance", 0, 200);
>     > +
>     > +       if (!disp->underscan_hborder_property ||
>     > +                       !disp->underscan_vborder_property ||
>     > +                       !disp->vibrant_hue_property ||
>     > +                       !disp->color_vibrance_property)
>     > +               return;
> 
>     Aren't we at the end of the function anyways?
> 
> 
> Sorry. it is not perfect patch 
> I found this by my static analyzer.
> I have limited knowledge about this driver.
> I don't want to mass up your driver.
> What I want to do is to tell you there is a bug.
> I think we need to return error to caller.
I'm not so sure we do.  We check for valid pointers for these when
they're actually used, so no OOPS will occur.  Worst case, the driver
still loads correctly with some missing properties.

Ben.

>  
> 
> 
>     >  }
>     >
>     >  int
>     > --
>     > 1.9.1
>     >
> 
> 
> 
> 
> -- 
> Regards
> Insu Yun


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ