linux-kernel - Re: [PATCH] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160129065133.7338cf2c@ipc1.ka-ro>
Date:	Fri, 29 Jan 2016 06:51:33 +0100
From:	Lothar Waßmann <LW@...O-electronics.de>
To:	Nicolin Chen <nicoleotsuka@...il.com>
Cc:	Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Liam Girdwood <lgirdwood@...il.com>,
	Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI
 depending on SoC type

Hi,

On Thu, 28 Jan 2016 15:08:47 -0800 Nicolin Chen wrote:
> On Thu, Jan 28, 2016 at 11:33:52PM +0100, Mark Brown wrote:
> > On Wed, Jan 20, 2016 at 01:30:38PM +0100, Lothar Waßmann wrote:
> > 
> > > -	select SND_SOC_FSL_SSI
> > > +	select SND_SOC_FSL_SAI if SOC_IMX6UL
> > > +	select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX
> > 
> > Does this card not work for older i.MXs (which had the same SSI/AUDMUX
> > combination as the majority of the i.MX6 family) as well?
> 
> It's widely used in older i.MXs according to their DTS files. So
> it should be safer to just leave SSI over here.
> 
Nothing prevents you to enable the SSI driver on any i.MX6 module.
The only change I made is to select the SAI driver instead of the SSI
driver on i.MX6UL because the i.MX6UL does not have an SSI unit!

> And I actually doubt the feasibility of running this driver with
> i.MX6UL as there might not be an AUDMUX on i.MX6UL since it does
> not have SSI any more while the driver always touches the address
> space of AUDMUX which may not exist on i.MX6UL.
>
#define this driver
The FSL_SAI driver does not touch the audmux address space in any way.
The simple-card audio driver works perfectly well with the FSL_SAI
driver on i.MX6UL.


Lothar Waßmann