linux-kernel - Re: [PATCH] Staging: Skein: Moved macros from skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160129063443.GA13752@kroah.com>
Date:	Thu, 28 Jan 2016 22:34:43 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Sanidhya Solanki <jpage.lkml@...il.com>,
	devel@...verdev.osuosl.org, Jason Cooper <jason@...edaemon.net>,
	mathieu.poirier@...aro.org, linux-kernel@...r.kernel.org,
	deepa.kernel@...il.com, vatikaharlalka@...il.com,
	brcnakalin@...il.com
Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to
 header file.

On Thu, Dec 17, 2015 at 12:46:14PM +0530, Sudip Mukherjee wrote:
> On Mon, Dec 14, 2015 at 07:08:08PM -0500, Sanidhya Solanki wrote:
> > The original code defined macros in the source code, making it
> > harder to read. Moved them to the header file, as per the TODO file.
> > 
> > Updated the TODO file.
> 
> I think the TODO file should not be updated now. There are still some
> macros in skein_block.c.

I agree, it can't be removed just yet, this patch needs to be redone
before I can take it.

thanks,

greg k-h