linux-kernel - Re: [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 23:57:23 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Shraddha Barke <shraddha.6596@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	Peter Senna Tschudin <peter.senna@...il.com>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support
 using managed version

On Sat, Jan 23, 2016 at 02:41:25AM +0530, Shraddha Barke wrote:
> setup_access_params_addr has 2 goals-
> 
> -Initialize the access_params field so that it can be used to send and read
> commands from the device in access_with_param
> -Get a bus address for the allocated memory to transfer to the device.
> 
> Replace the combination of devm_kzalloc and _pa() with dmam_alloc_coherent.
> Coherent mapping guarantees that the device and CPU are in sync.
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
> ---
> Changes in v3-
>  Both writel in the same style
> Changes in v2-
>  Updated commit message, use upper_32_bits and lower_32_bits
> 
>  drivers/platform/goldfish/goldfish_pipe.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Due to some other changes to this file, this doesn't apply to my
char-misc-testing tree.  Can you refresh it based on that and resend?

thanks,

greg k-h