[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87r3h07kx6.fsf@belgarion.home>
Date: Fri, 29 Jan 2016 11:13:41 +0100
From: Robert Jarzmik <robert.jarzmik@...e.fr>
To: Arnd Bergmann <arnd@...db.de>
Cc: Felipe Balbi <balbi@...nel.org>,
linux-arm-kernel@...ts.infradead.org, Felipe Balbi <balbi@...com>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
Haojian Zhuang <haojian.zhuang@...il.com>,
Daniel Mack <daniel@...que.org>,
Imre Kaloz <kaloz@...nwrt.org>,
Krzysztof Halasa <khalasa@...p.pl>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/7] usb: gadget: pxa25x_udc cleanup
Arnd Bergmann <arnd@...db.de> writes:
> This removes the dependency on the mach/hardware.h header file
> from the pxa25x_udc driver after the register definitions were
> already unified in the previous patch.
>
> Following the model of pxa27x_udc (and basically all other drivers
> in the kernel), we define the register numbers as offsets from
> the register base address and use accessor functions to read/write
> them.
>
> For the moment, this still leaves the direct pointer dereference
> in place, instead of using readl/writel, so this patch should
> not be changing the behavior of the driver, other than using
> ioremap() on the platform resource to replace the hardcoded
> virtual address pointers.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>
It's too bad coccinelle cannot make that work more automatic, isn't it ? :)
Cheers.
--
Robert
Powered by blists - more mailing lists