linux-kernel - Re: [PATCH v3] i2c: mt8173: add 4GB mode support in i2c driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201601291845.qFl2f6RN%fengguang.wu@intel.com>
Date:	Fri, 29 Jan 2016 18:23:58 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Liguo Zhang <liguo.zhang@...iatek.com>
Cc:	kbuild-all@...org, Wolfram Sang <wsa@...-dreams.de>,
	srv_heupstream@...iatek.com,
	Matthias Brugger <matthias.bgg@...il.com>,
	Eddie Huang <eddie.huang@...iatek.com>,
	Xudong Chen <xudong.chen@...iatek.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Liguo Zhang <liguo.zhang@...iatek.com>
Subject: Re: [PATCH v3] i2c: mt8173: add 4GB mode support in i2c driver.

Hi Liguo,

[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v4.5-rc1 next-20160129]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Liguo-Zhang/i2c-mt8173-add-4GB-mode-support-in-i2c-driver/20160129-174005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/for-next
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10:0,
                    from include/linux/clk.h:16,
                    from drivers/i2c/busses/i2c-mt65xx.c:15:
   drivers/i2c/busses/i2c-mt65xx.c: In function 'mtk_i2c_set_4g_mode':
   include/linux/bitops.h:6:24: warning: left shift count >= width of type [-Wshift-count-overflow]
    #define BIT(nr)   (1UL << (nr))
                           ^
>> drivers/i2c/busses/i2c-mt65xx.c:378:17: note: in expansion of macro 'BIT'
     return (addr & BIT(32)) ? I2C_DMA_4G_MODE : I2C_DMA_CLR_FLAG;
                    ^

vim +/BIT +378 drivers/i2c/busses/i2c-mt65xx.c

   362		if (target_speed > MAX_FS_MODE_SPEED) {
   363			/* Set the high speed mode register */
   364			i2c->timing_reg = I2C_FS_TIME_INIT_VALUE;
   365			i2c->high_speed_reg = I2C_TIME_DEFAULT_VALUE |
   366				(sample_cnt << 12) | (step_cnt << 8);
   367		} else {
   368			i2c->timing_reg = (sample_cnt << 8) | (step_cnt << 0);
   369			/* Disable the high speed transaction */
   370			i2c->high_speed_reg = I2C_TIME_CLR_VALUE;
   371		}
   372	
   373		return 0;
   374	}
   375	
   376	static inline u32 mtk_i2c_set_4g_mode(dma_addr_t addr)
   377	{
 > 378		return (addr & BIT(32)) ? I2C_DMA_4G_MODE : I2C_DMA_CLR_FLAG;
   379	}
   380	
   381	static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
   382				       int num, int left_num)
   383	{
   384		u16 addr_reg;
   385		u16 start_reg;
   386		u16 control_reg;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (53452 bytes)