linux-kernel - Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jan 2016 16:55:08 +0100
From:	khalasa@...p.pl (Krzysztof Hałasa)
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Felipe Balbi <balbi@...nel.org>, Imre Kaloz <kaloz@...nwrt.org>,
	Russell King <linux@....linux.org.uk>,
	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

Arnd Bergmann <arnd@...db.de> writes:

> This addresses both issues by moving all the definitions into the
> pxa25x_udc driver itself. It turns out the only difference between
> them was 'UDCCS_IO_ROF', and that could well be a mistake when it
> was incorrectly copied from pxa25x to ixp4xx.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Both the programming manual and the Intel's library code say it's
bit 2. Must be a mistake in the old code. Unfortunately I think we
won't be able to check it on real hardware, the UDC on IXP4xx boards
isn't usually connected. Also, this bug wouldn't likely affect
operation (unless there is an overflow event, which would be
currently undetected).

I guess we as well very safely change it to 1 << 2.

For the IXP4xx part,
Acked-by: Krzysztof Halasa <khalasa@...p.pl>
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland