| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <s5h8u38mjp3.wl-tiwai@suse.de>
Date: Fri, 29 Jan 2016 17:31:04 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Insu Yun <wuninsu@...il.com>
Cc: perex@...ex.cz, tiwai@...e.com, michael@...noth.net,
lambert.quentin@...il.com, pzubaj@...ticonet.sk,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
yeongjin.jang@...ech.edu, taesoo@...ech.edu, insu@...ech.edu,
changwoo@...ech.edu
Subject: Re: [alsa-devel] [PATCH v2] emu10k1: correctly handling failed thread creation
On Fri, 29 Jan 2016 16:56:11 +0100,
Insu Yun wrote:
>
> Since kthread_create can be failed, it needs to check
> whether error occurred and return error code.
>
> Signed-off-by: Insu Yun <wuninsu@...il.com>
Applied, thanks.
Takashi
> ---
> sound/pci/emu10k1/emu10k1_main.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
> index 28e2f8b..8914534 100644
> --- a/sound/pci/emu10k1/emu10k1_main.c
> +++ b/sound/pci/emu10k1/emu10k1_main.c
> @@ -1141,6 +1141,14 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu)
> emu->emu1010.firmware_thread =
> kthread_create(emu1010_firmware_thread, emu,
> "emu1010_firmware");
> + if (IS_ERR(emu->emu1010.firmware_thread)) {
> + err = PTR_ERR(emu->emu1010.firmware_thread);
> + emu->emu1010.firmware_thread = NULL;
> + dev_info(emu->card->dev,
> + "emu1010: Creating thread failed\n");
> + return err;
> + }
> +
> wake_up_process(emu->emu1010.firmware_thread);
> }
>
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
Powered by blists - more mailing lists