linux-kernel - Re: [PATCH] adv7511: Added mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1948106.WC7MId72vp@avalon>
Date:	Fri, 29 Jan 2016 19:48:35 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	David Airlie <airlied@...ux.ie>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Subject: Re: [PATCH] adv7511: Added mode_fixup function.

Hi Carlos,

Thank you for the patch.

On Friday 29 January 2016 10:33:47 Carlos Palminha wrote:
> The mode_fixup is necessary when using it in a DRM FB driver pipeline.

Instead of implementing stubs in encoder drivers, wouldn't it be better to 
make mode_fixup optional ?

> Signed-off-by: Carlos Palminha <palminha@...opsys.com>
> ---
>  drivers/gpu/drm/i2c/adv7511.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
> index 533d1e3..90082d2 100644
> --- a/drivers/gpu/drm/i2c/adv7511.c
> +++ b/drivers/gpu/drm/i2c/adv7511.c
> @@ -648,6 +648,13 @@ adv7511_encoder_detect(struct drm_encoder *encoder,
>  	return status;
>  }
> 
> +static bool adv7511_encoder_mode_fixup(struct drm_encoder *encoder,
> +					const struct drm_display_mode *mode,
> +					struct drm_display_mode *adjusted_mode)
> +{
> +	return true;
> +}
> +
>  static int adv7511_encoder_mode_valid(struct drm_encoder *encoder,
>  				      struct drm_display_mode *mode)
>  {
> @@ -754,6 +761,7 @@ static void adv7511_encoder_mode_set(struct drm_encoder
> *encoder,
> 
>  static const struct drm_encoder_slave_funcs adv7511_encoder_funcs = {
>  	.dpms = adv7511_encoder_dpms,
> +	.mode_fixup = adv7511_encoder_mode_fixup,
>  	.mode_valid = adv7511_encoder_mode_valid,
>  	.mode_set = adv7511_encoder_mode_set,
>  	.detect = adv7511_encoder_detect,

-- 
Regards,

Laurent Pinchart