linux-kernel - [tip:perf/urgent] perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-d4913cbd05bab685e49c8174896e563b2487d054@git.kernel.org>
Date:	Sat, 30 Jan 2016 00:24:57 -0800
From:	tip-bot for Markus Trippelsdorf <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	acme@...hat.com, matt@...eblueprint.co.uk, markus@...ppelsdorf.de,
	linux-kernel@...r.kernel.org, peterz@...radead.org,
	mingo@...nel.org, ben@...adent.org.uk, tglx@...utronix.de,
	hpa@...or.com
Subject: [tip:perf/urgent] perf annotate browser:
  Fix behaviour of Shift-Tab with nothing focussed

Commit-ID:  d4913cbd05bab685e49c8174896e563b2487d054
Gitweb:     http://git.kernel.org/tip/d4913cbd05bab685e49c8174896e563b2487d054
Author:     Markus Trippelsdorf <markus@...ppelsdorf.de>
AuthorDate: Mon, 14 Dec 2015 16:44:03 +0100
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Tue, 26 Jan 2016 11:14:25 -0300

perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed

The issue was pointed out by gcc-6's -Wmisleading-indentation.

Signed-off-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
Acked-by: Ingo Molnar <mingo@...nel.org>
Cc: Ben Hutchings <ben@...adent.org.uk>
Cc: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Peter Zijlstra <peterz@...radead.org>
Fixes: c97cf42219b7 ("perf top: Live TUI Annotation")
Link: http://lkml.kernel.org/r/20151214154403.GB1409@x4
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/ui/browsers/annotate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index d4d7cc2..718bd46 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -755,11 +755,11 @@ static int annotate_browser__run(struct annotate_browser *browser,
 				nd = browser->curr_hot;
 			break;
 		case K_UNTAB:
-			if (nd != NULL)
+			if (nd != NULL) {
 				nd = rb_next(nd);
 				if (nd == NULL)
 					nd = rb_first(&browser->entries);
-			else
+			} else
 				nd = browser->curr_hot;
 			break;
 		case K_F1: