linux-kernel - Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160130093124.GA14301@gmail.com>
Date:	Sat, 30 Jan 2016 10:31:24 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Brian Gerst <brgerst@...il.com>, "H. Peter Anvin" <hpa@...or.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>,
	tip-bot for Andy Lutomirski <tipbot@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>,
	Andy Lutomirski <luto@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Frédéric Weisbecker <fweisbec@...il.com>
Subject: Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and
 __SYSCALL_X32


* Andy Lutomirski <luto@...capital.net> wrote:

> >>>+      if [ "$abi" == "COMMON" -o "$abi" == "64" ]; then
> >>>+          # COMMON is the same as 64, except that we don't expect X32
> >>>+          # programs to use it.  Our expectation has nothing to do with
> >>>+          # any generated code, so treat them the same.
> >>>+          emit 64 "$nr" "$entry" "$compat"
> >>>+      elif [ "$abi" == "X32" ]; then
> >>>+          # X32 is equivalent to 64 on an X32-compatible kernel.
> >>>+          echo "#ifdef CONFIG_X86_X32_ABI"
> >>>+          emit 64 "$nr" "$entry" "$compat"
> >>>+          echo "#endif"
> >>>+      elif [ "$abi" == "I386" ]; then
> >>>+          emit "$abi" "$nr" "$entry" "$compat"
> >>>+      else
> >>>+          echo "Unknown abi $abi" >&2
> >>>+          exit 1
> >>>+      fi

> No combinatorial explosion, please.  We could use __SYSCALL(nr, sym,
> abi, qual), though.

Mind fixing it, so that we get back the arch-neutral property?

Thanks,

	Ingo