linux-kernel - Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANpvso5wg_Zz7VSRDeKamx0XCCcjr3y+i2UKNFLe+BZEofEG_A@mail.gmail.com>
Date:	Sat, 30 Jan 2016 16:55:59 +0000
From:	Eric Curtin <ericcurtin17@...il.com>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Joe Perches <joe@...ches.com>, platform-driver-x86@...r.kernel.org,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Darren Hart <dvhart@...radead.org>,
	ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"

On 30 January 2016 at 12:20, Henrique de Moraes Holschuh <hmh@....eng.br> wrote:
> On Wed, 27 Jan 2016, Joe Perches wrote:
>> On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
>> > Message gets logged on machines that are well supported.
>> >
>> > Signed-off-by: Eric Curtin <ericcurtin17@...il.com>
>> > ---
>> >  drivers/platform/x86/thinkpad_acpi.c | 1 -
>> >  1 file changed, 1 deletion(-)
>> >
>> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
>> > b/drivers/platform/x86/thinkpad_acpi.c
>> > index a268a7a..4eb41aa 100644
>> > --- a/drivers/platform/x86/thinkpad_acpi.c
>> > +++ b/drivers/platform/x86/thinkpad_acpi.c
>> > @@ -6661,7 +6661,6 @@ static void __init
>> > tpacpi_detect_brightness_capabilities(void)
>> >                 pr_info("detected a 8-level brightness capable
>> > ThinkPad\n");
>> >                 break;
>> >         default:
>> > -               pr_info("Unsupported brightness interface\n");
>> >                 tp_features.bright_unkfw = 1;
>> >                 bright_maxlvl = b - 1;
>> >         }
>>
>> Perhaps this should be something like this instead:
>> ---
>>  drivers/platform/x86/thinkpad_acpi.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
>> index a268a7a..bd12c71 100644
>> --- a/drivers/platform/x86/thinkpad_acpi.c
>> +++ b/drivers/platform/x86/thinkpad_acpi.c
>> @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
>>       switch (b) {
>>       case 16:
>>               bright_maxlvl = 15;
>> -             pr_info("detected a 16-level brightness capable ThinkPad\n");
>>               break;
>>       case 8:
>>       case 0:
>>               bright_maxlvl = 7;
>> -             pr_info("detected a 8-level brightness capable ThinkPad\n");
>>               break;
>>       default:
>> -             pr_info("Unsupported brightness interface\n");
>>               tp_features.bright_unkfw = 1;
>>               bright_maxlvl = b - 1;
>>       }
>> +     pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
>>  }
>
> This can be made pr_debug, since we're touching it...
>
> --
>   "One disk to rule them all, One disk to find them. One disk to bring
>   them all and in the darkness grind them. In the Land of Redmond
>   where the shadows lie." -- The Silicon Valley Tarot
>   Henrique Holschuh

"Unsupported brightness interface" message gets logged on
 machines that are well supported.

Signed-off-by: Eric Curtin <ericcurtin17@...il.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index a268a7a..e305ab5 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6653,18 +6653,16 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
        switch (b) {
        case 16:
                bright_maxlvl = 15;
-               pr_info("detected a 16-level brightness capable ThinkPad\n");
                break;
        case 8:
        case 0:
                bright_maxlvl = 7;
-               pr_info("detected a 8-level brightness capable ThinkPad\n");
                break;
        default:
-               pr_info("Unsupported brightness interface\n");
                tp_features.bright_unkfw = 1;
                bright_maxlvl = b - 1;
        }
+       pr_debug("detected %u brightness levels\n", bright_maxlvl + 1);
 }

 static int __init brightness_init(struct ibm_init_struct *iibm)
-- 
2.5.0