linux-kernel - Re: [PATCH 0/4] alienware-wmi new platform and feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160130173423.GB9269@malice.jf.intel.com>
Date:	Sat, 30 Jan 2016 09:34:23 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Mario Limonciello <mario_limonciello@...l.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 0/4] alienware-wmi new platform and feature support

On Thu, Jan 21, 2016 at 06:04:56PM -0600, Mario Limonciello wrote:
> I've got some extensions for the alienware-wmi driver that have
> been introduced for a few new platforms and can be controlled via the WMI
> interface.
> 
> Mario Limonciello (4):
>   Add support for new platform, X51-R3
>   Add support for alienware graphics amplifier
>   Add support for deep sleep control.
>   Add support for two new systems: ASM200 & ASM201

Hi Mario,

I gave these a quick scan without context from a commit message, and didn't
observe anything particularly troubling. Just a couple minor nits regarding
formatting (new lines to keep from going over 80 characters in a couple places
that weren't really necessary).

Please add commit messages to the series that will provide the reviewer and
future readers with the context they need to understand the motivation for the
patch and the intended approach against which to compare the implementation.

Thanks,

> 
>  drivers/platform/x86/alienware-wmi.c | 285 +++++++++++++++++++++++++++++++----
>  1 file changed, 252 insertions(+), 33 deletions(-)
> 
> -- 
> 1.9.1
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center