linux-kernel - Re: Build failure: -Wno-unused-const-variable DNE on old GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1454175435.7329.22.camel@perches.com>
Date:	Sat, 30 Jan 2016 09:37:15 -0800
From:	Joe Perches <joe@...ches.com>
To:	"Maciej W. Rozycki" <macro@...tec.com>,
	Brian Norris <computersforpeace@...il.com>
Cc:	Michal Marek <mmarek@...e.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Anton Blanchard <anton@....ibm.com>,
	Ian Munsie <imunsie@....ibm.com>,
	Michael Neuling <mikey@...ling.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Olof Johansson <olof@...om.net>
Subject: Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Sat, 2016-01-30 at 14:20 +0000, Maciej W. Rozycki wrote:
> On Thu, 7 Jan 2016, Brian Norris wrote:
> 
> > > Perhaps most uses of -Werror without some CONFIG_ guard
> > > should be removed or replaced by some other mechanism.
> > 
> > +1000. I'd personally like to see all one-off uses of -Werror removed.
> > 
> > > $ git grep -E "=\s*\-Werror" | grep -v CONFIG
> > > [...]
> > > arch/alpha/lib/Makefile:ccflags-y := -Werror
> > > arch/alpha/mm/Makefile:ccflags-y := -Werror
> > > arch/alpha/oprofile/Makefile:ccflags-y := -Werror -Wno-sign-compare
> > > arch/metag/oprofile/Makefile:ccflags-y	+= -Werror
> > > arch/mips/Kbuild:subdir-ccflags-y := -Werror
> > 
> > ^^ I always patch this one out when build-testing MIPS, since I like to
> > turn up warning levels (e.g., W=1), but not kill the build entirely.
> 
>  The MIPS port switched on -Werror years ago, because people submitted 
> awful code and couldn't be bothered unless the build crashed.  You're 
> welcome to patch your own tree, however I maintain it was a very good 
> decision, and TBH I think -Werror should be on globally.

That'd be easy to do with some CONFIG_COMPILER_ERROR type
rather than in specific directory Makefiles