linux-kernel - Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wrfjfuxd2529.fsf@redhat.com>
Date:	Sun, 31 Jan 2016 09:31:58 -0500
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Julian Calaby <julian.calaby@...il.com>
Cc:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joe Perches <joe@...ches.com>,
	Alexander Kuleshov <kuleshovmail@...il.com>,
	Haneen Mohammed <hamohammed.sa@...il.com>,
	Andreas Ruprecht <andreas.ruprecht@....de>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	"devel\@driverdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Julian Calaby <julian.calaby@...il.com> writes:
> Hi Bhaktipriya,
>
> On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen <Jes.Sorensen@...hat.com> wrote:
>> Bhaktipriya Shridhar <bhaktipriya96@...il.com> writes:
>> If you insist on pushing this rather unncessary change, please do it
>> properly, and remove the blank line before the return statement as well.
>
> As Jes said, you need to remove the blank lines before the returns
> too. checkpatch should have picked this up, you did run the patch
> through checkpatch before you sent it, right?
>
> Jes,
>
> I know you have strong feelings on coding style, but there are a lot
> of people out there who see deviations from the standard as bugs to be
> fixed, so stuff like this isn't going to stop until it matches the
> coding style document's spec.

Julian,

rtl8723au is pretty dead development wise, so I don't care too much.
checkpatch is broken and has effectively turned into a policing tool for
a few people who wish to apply their narrow view onto everyone else.
I'll continue top reject broken patches to my code pushed out under
those rules.

Maybe it's time to introduce checkpatchconsideredharmful.com

Jes