linux-kernel - Re: [PATCH 00/14] USB: serial: Fix coccinelle warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 31 Jan 2016 21:10:21 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Mathieu OTHACEHE <m.othacehe@...il.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 00/14] USB: serial: Fix coccinelle warnings

On Sat, Jan 30, 2016 at 06:44:33PM +0100, Mathieu OTHACEHE wrote:
> This series of patches fixes all coccinelle warnings in
> USB serial subsystem
> 
> Mathieu OTHACEHE (14):
>   USB: serial: safe_serial: fix assignment of bool to 0/1
>   USB: serial: safe_serial: fix assignment of bool to non 0/1 constant
>   USB: serial: quatech2: remove comparison to bool
>   USB: serial: iuu_phoenix: remove comparison of bool
>   USB: serial: mos7840: remove comparison to bool
>   USB: serial: garmin_gps: move constants to right
>   USB: serial: ftdi_sio: move constants to right
>   USB: serial: keyspan: remove unused semicolon
>   USB: serial: cyberjack: remove unneeded variable
>   USB: serial: garmin_gps: remove unneeded variable
>   USB: serial: mos7840: move constants to right
>   USB: serial: ch341: move constants to right
>   USB: serial: f81232: move constants to right
>   USB: serial: kl5kusb105: remove unneeded semicolons

Please squash these per type (or larger class) of issue you're fixing,
at least when the diffs aren't too big. No need to remove two semicolons
in two patches, etc.

Thanks,
Johan