| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Jan 2016 14:06:25 +0800
From: Chen-Yu Tsai <wens@...e.org>
To: Vishnu Patekar <vishnupatekar0510@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Maxime Ripard <maxime.ripard@...e-electrons.com>,
Russell King - ARM Linux <linux@....linux.org.uk>,
Emilio Lopez <emilio@...pez.com.ar>,
Jens Kuske <jenskuske@...il.com>,
Hans De Goede <hdegoede@...hat.com>,
Chen-Yu Tsai <wens@...e.org>,
devicetree <devicetree@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-sunxi <linux-sunxi@...glegroups.com>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...eaurora.org>,
Reinder de Haan <patchesrdh@...as.com>,
linux-clk <linux-clk@...r.kernel.org>
Subject: Re: [PATCH 07/14] ARM: dts: sun8i-a83t: Add basic clocks and resets
On Sun, Jan 31, 2016 at 9:20 AM, Vishnu Patekar
<vishnupatekar0510@...il.com> wrote:
> This adds A83T system bus clocks, bus gates, and clock resets.
>
> For ahb1 and ahb2, it's not clear which reset belongs to ahb1
> or ahb2; so named as ahb_reset0, ahb_reset1, ahb_reset2.
>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@...il.com>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 127 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 125 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 45b725c..568d6fb 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -146,6 +146,98 @@
> clocks = <&osc16M>;
> clock-output-names = "osc16Md512";
> };
> +
> +
extra newline.
> + pll6: clk@...20028 {
> + #clock-cells = <0>;
> + compatible = "allwinner,sun9i-a80-pll4-clk";
> + reg = <0x01c20028 0x4>;
> + clocks = <&osc24M>;
> + clock-output-names = "pll6";
> + };
> +
> + pll6d2: pll6d2_clk {
> + #clock-cells = <0>;
> + compatible = "fixed-factor-clock";
> + clock-div = <2>;
> + clock-mult = <1>;
> + clocks = <&pll6>;
> + clock-output-names = "pll6d2";
> + };
> +
> + ahb1: ahb1_clk@...20054 {
> + #clock-cells = <0>;
> + compatible = "allwinner,sun8i-a83t-ahb1-clk";
> + reg = <0x01c20054 0x4>;
> + clocks = <&osc16Md512>, <&osc24M>, <&pll6>, <&pll6>;
> + clock-output-names = "ahb1";
> + };
> +
> + ahb2: ahb2_clk@...2005c {
Just "clk" will do. We use "ahb1_clk" and "apb1_clk" because they have
the same address.
> + #clock-cells = <0>;
> + compatible = "allwinner,sun8i-h3-ahb2-clk";
> + reg = <0x01c2005c 0x4>;
> + clocks = <&ahb1>, <&pll6d2>;
> + clock-output-names = "ahb2";
> + };
> +
> + apb1: apb1_clk@...20054 {
> + #clock-cells = <0>;
> + compatible = "allwinner,sun8i-a83t-apb1-clk";
> + reg = <0x01c20054 0x4>;
> + clocks = <&ahb1>;
> + clock-output-names = "apb1";
> + };
Keep these ordered by register address, not clock name.
> +
> + apb2: clk@...20058 {
> + #clock-cells = <0>;
> + compatible = "allwinner,sun4i-a10-apb1-clk";
> + reg = <0x01c20058 0x4>;
> + clocks = <&osc16Md512>, <&osc24M>, <&pll6>, <&pll6>;
> + clock-output-names = "apb2";
> + };
> +
> + bus_gates: clk@...20060 {
> + #clock-cells = <1>;
> + compatible = "allwinner,sun8i-a83t-bus-gates-clk";
> + reg = <0x01c20060 0x10>;
> + clocks = <&ahb1>, <&ahb2>, <&apb1>, <&apb2>;
> + clock-names = "ahb1", "ahb2", "apb1", "apb2";
> + clock-indices = <1>, <5>, <6>,
> + <8>, <9>, <10>,
> + <13>, <14>, <17>,
> + <19>, <20>,
> + <21>, <24>,
> + <26>, <27>,
> + <29>, <32>,
> + <36>, <37>,
> + <40>, <43>,
> + <44>, <52>, <53>,
> + <54>, <65>,
> + <69>, <76>, <77>,
> + <78>, <79>, <96>,
> + <97>, <98>,
> + <112>, <113>,
> + <114>, <115>,
> + <116>;
> + clock-output-names = "bus_mipidsi", "bus_ss", "bus_dma",
> + "bus_mmc0", "bus_mmc1", "bus_mmc2",
> + "bus_nand", "bus_sdram", "bus_emac",
> + "bus_hstimer", "bus_spi0",
> + "bus_spi1", "bus_usb_drd",
"bus_usb_otg" would better match what we use for other SoCs.
> + "bus_ehci0", "bus_ehci1",
> + "bus_ohci0", "bus_ve",
> + "bus_lcd0", "bus_lcd1",
> + "bus_csi", "bus_hdmi",
> + "bus_de", "bus_gpu", "bus_msgbox",
> + "bus_spinlock", "bus_owa",
Use "bus_spdif" instead of "bus_owa".
> + "bus_pio", "bus_i2s0", "bus_i2s1",
> + "bus_i2s2", "bus_tdm", "bus_i2c0",
> + "bus_i2c1", "bus_i2c2",
> + "bus_uart0", "bus_uart1",
> + "bus_uart2", "bus_uart3",
> + "bus_uart4";
> + };
> };
>
> soc {
> @@ -160,7 +252,7 @@
> <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0x01c20800 0x400>;
> - clocks = <&osc24M>;
> + clocks = <&bus_gates 69>;
> gpio-controller;
> interrupt-controller;
> #interrupt-cells = <3>;
> @@ -189,6 +281,36 @@
> };
> };
>
> + ahb_reset0: reset@...202c0 {
> + reg = <0x01c202c0 0x4>;
> + compatible = "allwinner,sun6i-a31-clock-reset";
> + #reset-cells = <1>;
> + };
> +
> + ahb_reset1: reset@...202c4 {
> + reg = <0x01c202c4 0x4>;
> + compatible = "allwinner,sun6i-a31-clock-reset";
> + #reset-cells = <1>;
> + };
> +
> + ahb_reset2: reset@...202c8 {
> + reg = <0x01c202c8 0x4>;
> + compatible = "allwinner,sun6i-a31-clock-reset";
> + #reset-cells = <1>;
> + };
You can combine these 3. The reset driver can handle multiple
contiguous registers.
See the H3 dtsi.
ChenYu
> +
> + apb1_reset: reset@...202d0 {
> + reg = <0x01c202d0 0x4>;
> + compatible = "allwinner,sun6i-a31-clock-reset";
> + #reset-cells = <1>;
> + };
> +
> + apb2_reset: reset@...202d8 {
> + reg = <0x01c202d8 0x4>;
> + compatible = "allwinner,sun6i-a31-clock-reset";
> + #reset-cells = <1>;
> + };
> +
> timer@...20c00 {
> compatible = "allwinner,sun4i-a10-timer";
> reg = <0x01c20c00 0xa0>;
> @@ -210,7 +332,8 @@
> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> reg-shift = <2>;
> reg-io-width = <4>;
> - clocks = <&osc24M>;
> + clocks = <&bus_gates 112>;
> + resets = <&apb2_reset 16>;
> status = "disabled";
> };
>
> --
> 1.9.1
>
Powered by blists - more mailing lists