linux-kernel - Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160131120822.GN20165@piout.net>
Date:	Sun, 31 Jan 2016 13:08:22 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	Javier Martinez Canillas <javier@....samsung.com>,
	Andi Shyti <andi.shyti@...sung.com>,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output

On 27/01/2016 at 15:46:11 +0900, Krzysztof Kozlowski wrote :
> Cleanup of entire driver of its dmesg output:
> 1. Remove printing of the function name, because printing device name is
>    sufficient. This also makes the dev_err()-like functions more compact
>    and readable (not need of line break).
> 2. Lower from info to debug printing of each RTC interrupt (no need to
>    make noise on each alarm).
> 3. Remove dev_info() at beginning of probe because a message is already
>    always printed by either probe failure or from registering the RTC
>    device as /dev/rtcX.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> ---
> 
> Patch rebased on top of Javier's v4:
> [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support
> http://www.spinics.net/lists/arm-kernel/msg477194.html
> 
> Feel free to join with these series.
> ---
>  drivers/rtc/rtc-max77686.c | 39 ++++++++++++++-------------------------
>  1 file changed, 14 insertions(+), 25 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com