linux-kernel - Re: [PATCH] staging: rtl8192u: Fix block comments use * on subsequent lines in r8192U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOxTRzqmtXbs9w1UFkBgON4mWcmOXg8sQug1Xzo6PhxObq+_+g@mail.gmail.com>
Date:	Mon, 1 Feb 2016 16:31:22 +0900
From:	ByeoungWook Kim <quddnr145@...il.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	gregkh@...uxfoundation.org, ksenija.stanojevic@...il.com,
	luisbg@....samsung.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Fix block comments use * on subsequent
 lines in r8192U_wx.c

The current realtek driver was written like my patch comments. but
Documentation/CodingStyle isn't before.
So I wrote patch like current realtek driver.

How should i do it?

Regards,
Byeoungwook.

2016-02-01 16:01 GMT+09:00 Julia Lawall <julia.lawall@...6.fr>:
>
>
> On Mon, 1 Feb 2016, Byeoungwook Kim wrote:
>
>> clean up checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: Byeoungwook Kim <quddnr145@...il.com>
>> ---
>>  drivers/staging/rtl8192u/r8192U_wx.c | 38 +++++++++++++++++++-----------------
>>  1 file changed, 20 insertions(+), 18 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
>> index 4911fef..f828e64 100644
>> --- a/drivers/staging/rtl8192u/r8192U_wx.c
>> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
>> @@ -1,21 +1,23 @@
>> -/*
>> -   This file contains wireless extension handlers.
>> -
>> -   This is part of rtl8180 OpenSource driver.
>> -   Copyright (C) Andrea Merello 2004-2005  <andrea.merello@...il.com>
>> -   Released under the terms of GPL (General Public Licence)
>> -
>> -   Parts of this driver are based on the GPL part
>> -   of the official realtek driver.
>> -
>> -   Parts of this driver are based on the rtl8180 driver skeleton
>> -   from Patric Schenke & Andres Salomon.
>> -
>> -   Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
>> -
>> -   We want to thank the Authors of those projects and the Ndiswrapper
>> -   project Authors.
>> -*/
>> +/******************************************************************************
>
> Is the row of *s needed?
>
> julia
>
>> + *
>> + * This file contains wireless extension handlers.
>> + *
>> + * This is part of rtl8180 OpenSource driver.
>> + * Copyright (C) Andrea Merello 2004-2005  <andrea.merello@...il.com>
>> + * Released under the terms of GPL (General Public Licence)
>> + *
>> + * Parts of this driver are based on the GPL part
>> + * of the official realtek driver.
>> + *
>> + * Parts of this driver are based on the rtl8180 driver skeleton
>> + * from Patric Schenke & Andres Salomon.
>> + *
>> + * Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver.
>> + *
>> + * We want to thank the Authors of those projects and the Ndiswrapper
>> + * project Authors.
>> + *
>> + *****************************************************************************/
>>
>>  #include <linux/string.h>
>>  #include "r8192U.h"
>> --
>> 2.5.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>