linux-kernel - Re: [PATCH 0/3] x86/entry/64: Fixes for syscall rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Feb 2016 08:58:02 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Andy Lutomirski <luto@...nel.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Brian Gerst <brgerst@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 0/3] x86/entry/64: Fixes for syscall rework


* Borislav Petkov <bp@...en8.de> wrote:

> On Sun, Jan 31, 2016 at 09:33:25AM -0800, Andy Lutomirski wrote:
> > I broke iopl(2) with my syscall rework.  Fix it up.  While debugging
> > it, I found a bug in my IRQ state handling.  Fix that, too.
> > 
> > Andy Lutomirski (3):
> >   x86/entry/64: Fix an IRQ state error on ptregs-using syscalls
> >   x86/entry/64: Fix fast-path syscall return register state
> >   x86/syscalls/64: Mark sys_iopl as using ptregs
> > 
> >  arch/x86/entry/entry_64.S              | 23 ++++++++++++++++-------
> >  arch/x86/entry/syscalls/syscall_64.tbl |  2 +-
> >  2 files changed, 17 insertions(+), 8 deletions(-)
> 
> Looks good so far:
> 
> Reported-and-tested-by: Borislav Petkov <bp@...e.de>
> 
> We better hammer on those a lot more until the next merge window for
> more confidence.

Yes, this is why I started merging this right after -rc1.

In particular it would be interesting to get feedback from our 'special' syscall 
ABI users: emulators (Wine, Steam, etc.) and non-GNU toolchains (Android-x86) - at 
least the ones that utilize 64-bit syscalls.

Thanks,

	Ingo