linux-kernel - RE: [PATCH] cputime: Fix timeval-->cputime conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1602010942150.25254@nanos>
Date:	Mon, 1 Feb 2016 09:43:14 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Zengtao (B)" <prime.zeng@...ilicon.com>
cc:	Arnd Bergmann <arnd@...db.de>, LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: RE: [PATCH] cputime: Fix timeval-->cputime conversion

On Mon, 1 Feb 2016, Zengtao (B) wrote:

> Hi Arnd:
> 	I have got a new idea about the problem: 
> In include/linux/time64.h
> #define NSEC_PER_SEC	1000000000L 
> I think we should change it to
> #define NSEC_PER_SEC	1000000000LL 
> 
> My reason is :
> 1.  when it is used in a multiplication, it will easily get overflow.
> 2.  when it don't get overflow, the change has no side affect.

That's not a good idea. NSEC_PER_SEC is used in lots of places with 32bit
storage. I really don't want to mop up all the fallout.

Thanks,

	tglx