linux-kernel - Re: [PATCH][v2] ACPI: Do not report _OSI("Darwin") when acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdaNFVA10X_N-URqmKAv3upOF2zT083T0tiN1=DnLqNbA@mail.gmail.com>
Date:	Mon, 1 Feb 2016 10:54:26 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Chen Yu <yu.c.chen@...el.com>
Cc:	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, matthew.garrett@...ula.com,
	"Zhang, Rui" <rui.zhang@...el.com>
Subject: Re: [PATCH][v2] ACPI: Do not report _OSI("Darwin") when
 acpi_osi=!Darwin provided

On Mon, Feb 1, 2016 at 4:26 AM, Chen Yu <yu.c.chen@...el.com> wrote:
> Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always
> reports positive value when Apple hardware queries _OSI("Darwin").
> But sometimes the users might want to tell the hardware they don't
> need the Darwin feature, for example, users may leverage the hardware
> to power off the Thunderbolt, by appending acpi_osi=!Darwin in command
> line, thus Apple hardware regards it as an incompatible OS X system,
> hence turns off the Thunderbolt.


> +static bool acpi_osi_setup_disabled(char *str)
> +{
> +       int i;
> +       struct osi_setup_entry *osi;
> +
> +       if (!str)
> +               return false;
> +
> +       for (i = 0; i < OSI_STRING_ENTRIES_MAX; i++) {
> +               osi = &osi_setup_entries[i];
> +               if (!strcmp(osi->string, str)) {

Seems like we have one more user for
http://www.spinics.net/lists/kernel/msg2157535.html

> +                       if (!osi->enable)
> +                               return true;
> +                       else
> +                               return false;

return !osi->enable;

> +               }
> +       }
> +
> +       return false;
> +}


-- 
With Best Regards,
Andy Shevchenko