linux-kernel - RE: [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Feb 2016 10:40:25 -0000
From:	ygardi@...eaurora.org
To:	"Winkler, Tomas" <tomas.winkler@...el.com>
Cc:	"Yaniv Gardi" <ygardi@...eaurora.org>,
	"robherring2@...il.com" <robherring2@...il.com>,
	"James.Bottomley@...senPartnership.com" 
	<james.bottomley@...senpartnership.com>,
	"pebolle@...cali.nl" <pebolle@...cali.nl>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"santoshsy@...il.com" <santoshsy@...il.com>,
	"linux-scsi-owner@...r.kernel.org" <linux-scsi-owner@...r.kernel.org>,
	"subhashj@...eaurora.org" <subhashj@...eaurora.org>,
	"gbroner@...eaurora.org" <gbroner@...eaurora.org>,
	"draviv@...eaurora.org" <draviv@...eaurora.org>,
	"Maya Erez" <merez@...eaurora.org>,
	"Vinayak Holikatti" <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...n.com>
Subject: RE: [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before
 new transfers

>
>
>> +	cdb_len = min_t(unsigned short, lrbp->cmd->cmd_len, MAX_CDB_SIZE);
>> +	memcpy(ucd_req_ptr->sc.cdb, lrbp->cmd->cmnd, cdb_len);
>> +	if (cdb_len < MAX_CDB_SIZE)
>> +		memset(ucd_req_ptr->sc.cdb + cdb_len, 0,
>> +		       (MAX_CDB_SIZE - cdb_len));
> It's just 16 bytes, setting all to zero prior  to copy will be as good as
> this if statement
> memset(ucd_req_ptr->sc.cdb, 0, MAX_CDB_SIZE);
>

i agree. will be modified in V7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>