linux-kernel - Re: [PATCH 1/2] STAGING: COMEDI: Remove unnecessary typecast of c90 int constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <56AF3E9C.1040000@mev.co.uk>
Date:	Mon, 1 Feb 2016 11:16:44 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	"Pablo G. Gallardo" <gallardo_pablo@...mail.com>, greg@...ah.com
Cc:	hsweeten@...ionengravers.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] STAGING: COMEDI: Remove unnecessary typecast of c90
 int constant

On 01/02/16 01:06, Pablo G. Gallardo wrote:
> This patch removes unnecessary typecast of c90 int constant.
>
> Signed-off-by: Pablo G. Gallardo <gallardo_pablo@...mail.com>
> ---
>   drivers/staging/comedi/comedi.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 83bd309..2645081 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -516,7 +516,7 @@ struct comedi_bufinfo {
>   #define UNIT_mA			1
>   #define UNIT_none		2
>
> -#define COMEDI_MIN_SPEED	((unsigned int)0xffffffff)
> +#define COMEDI_MIN_SPEED	(0xffffffff)

Those parentheses are unnecessary as well.  I'd probably add a 'u' 
suffix to the constant to avoid any possibility of it being 
misinterpreted as a negative value by a pre-C90 version of the C 
language, though that's probably not worth worrying about.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-