linux-kernel - Re: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Feb 2016 14:04:48 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Grygorii Strashko <grygorii.strashko@...com>,
	Mike Galbraith <umgwanakikbuti@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-rt-users <linux-rt-users@...r.kernel.org>
Subject: Re: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port

On 01/25/2016 06:14 PM, Grygorii Strashko wrote:

>> diff --git a/arch/arm/kernel/entry-common.S
>> b/arch/arm/kernel/entry-common.S
>> index 30a7228eaceb..c3bd6cbfce4b 100644
>> --- a/arch/arm/kernel/entry-common.S
>> +++ b/arch/arm/kernel/entry-common.S
>> @@ -36,7 +36,9 @@
>>    UNWIND(.cantunwind    )
>>       disable_irq_notrace            @ disable interrupts
>>       ldr    r1, [tsk, #TI_FLAGS]        @ re-check for syscall tracing
>> -    tst    r1, #_TIF_SYSCALL_WORK | _TIF_WORK_MASK
>> +    tst    r1, #((_TIF_SYSCALL_WORK | _TIF_WORK_MASK) & ~_TIF_SECCOMP)
>> +    bne    fast_work_pending
>         ^^^^^^^^^^^^^^^^
> 
>> +    tst    r1, #_TIF_SECCOMP
>>       bne    fast_work_pending
>         ^^^^^^^^^^^^^^^^^
> 
> Should it be "fast_work_pending" in both cases?

Yes, I think so and it is, isn't it?
The original is

     tst    r1, #_TIF_SYSCALL_WORK | _TIF_WORK_MASK
     bne    fast_work_pending

and with the LAZY bits in it, the ASM opcode no longer works because
the constant is too large (or has to many bits set). So I removed the
_TIF_SECCOMP bit out of the mask and made two compare & jumps here.

Sebastian