linux-kernel - Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Feb 2016 10:15:25 -0300
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Lee Jones <lee.jones@...aro.org>,
	Peter Korsgaard <jacmet@...il.com>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A

Hello Wenyou,

[snip]

>> >
>> > If then device is not being loaded from the DT (and it shouldn't be,
>> > the device looks like it should be instantiated directly by the MFD as
>> > it can't exist separately to that MFD) an OF table will do nothing.
>>
>> Then he should remove the .of_compatible from the MFD cell definition.
>
> I tried it,
>
> But if removed this .of_compatible, and reserved the OF table.

What we said is that you should remove both the mfd cell
.of_compatible field and the OF table. Of course removing one but
leaving the other is not correct.

> the &pdev->dev->of_node is NULL, the driver fails to get the configuration value from DT,
>

I see, you mean that you are not able to lookup the
"active-semi,vsel-high" property.

> It seems the OF table still doesn't work. Where is wrong?
>

I think the problem is with your DT binding. You have a PMIC dev node
with compatible "active-semi,act8945a" that has a child node with
compatible "active-semi,act8945a-regulator" which in turn has the
"regulators" node.

I believe what Mark says is that there shouldn't be a compatible and
node for the regulators IC since is part of the PMIC. IOW, you can't
have it as a standalone node in the DTS.

> Could you help give some suggestion?
>

I would just remove the "active-semi,act8945a-regulator" node and make
"active-semi,vsel-high" a property of the "active-semi,act8945a" node.
That way you can remove the mfd cell .of_compatible and OF table in
the regulator driver and read the "active-semi,vsel-high" using the
platform device's parent of_node.

But it's better if you wait for Mark's opinions before re-spining your patches.

Best regards,
Javier