linux-kernel - Re: [PATCH V5 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160201135817.GA25324@rob-hp-laptop>
Date:	Mon, 1 Feb 2016 07:58:17 -0600
From:	Rob Herring <robh@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linus.walleij@...aro.org, gnurou@...il.com, lee.jones@...aro.org,
	broonie@...nel.org, a.zummo@...ertech.it,
	alexandre.belloni@...e-electrons.com, lgirdwood@...il.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, rtc-linux@...glegroups.com,
	swarren@...dia.com, treding@...dia.com, k.kozlowski@...sung.com,
	Chaitanya Bandi <bandik@...dia.com>
Subject: Re: [PATCH V5 3/5] pinctrl: max77620: add pincontrol driver for
 MAX77620/MAX20024

On Wed, Jan 27, 2016 at 07:40:06PM +0530, Laxman Dewangan wrote:
> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
> which also act as the special function in alternate mode. Also
> there is configuration like push-pull, open drain, FPS timing
> etc for these pins.
> 
> Add pincontrol driver to configure these parameters through
> pincontrol APIs.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Signed-off-by: Chaitanya Bandi <bandik@...dia.com>
> ---
> Changes from V1:
> - Cleanup code based on comment received on mfd/rtc.
> - Avoid duplication on error message.
>  
> Changes form V2:
> - Run coccicheck and checkpatch in strict mode for the alignment.
> - update based on api changes from core.
> 
> Changes from V3: 
> - Change all sys initcall to module driver.
> - change the max77620_read argument to unisgned int from u8.
> 
> Changes from V4: 
> - Added DT binding document as devicetree/bindings/pinctrl/pinctrl-max77620.txt
> - Detail out properties.
> 
>  .../bindings/pinctrl/pinctrl-max77620.txt          |  87 +++

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/pinctrl/Kconfig                            |  10 +
>  drivers/pinctrl/Makefile                           |   1 +
>  drivers/pinctrl/pinctrl-max77620.c                 | 693 +++++++++++++++++++++
>  4 files changed, 791 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-max77620.txt
>  create mode 100644 drivers/pinctrl/pinctrl-max77620.c