linux-kernel - Re: [PATCH v4.4-rc8] jffs2: xattr: Silence frame size warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Feb 2016 14:48:50 +0000
From:	David Woodhouse <dwmw2@...radead.org>
To:	tim.gardner@...onical.com, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4.4-rc8] jffs2: xattr: Silence frame size warning

On Thu, 2016-01-07 at 12:11 -0700, tim.gardner@...onical.com wrote:
> From: Tim Gardner <tim.gardner@...onical.com>
> 
> fs/jffs2/xattr.c: In function 'jffs2_build_xattr_subsystem':
> fs/jffs2/xattr.c:887:1: warning: the frame size of 1128 bytes is
> larger than 1024 bytes [-Wframe-larger-than=]
>  }

At first glance, that looks like it's just bypassing the entire
contents of that function if the allocation fails, leaving the various
data structures in an inconsistent state and raw node refs unchecked,
which will lead to lots of issues later once the mount has completed
and GC can never get unstuck.

So at the very least, your commit message is lacking the explanation of
what the implications are, and *why* you have satisfied yourself that
it's actually OK.

At worst, the patch is entirely broken.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5691 bytes)