linux-kernel - Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160201151305.GA9558@rob-hp-laptop>
Date:	Mon, 1 Feb 2016 09:13:05 -0600
From:	Rob Herring <robh@...nel.org>
To:	Stefan Agner <stefan@...er.ch>
Cc:	dmitry.torokhov@...il.com, michael.hennerich@...log.com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, realmz6@...il.com, broonie@...nel.org,
	jic23@...nel.org, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree
 support

On Fri, Jan 29, 2016 at 03:48:15PM -0800, Stefan Agner wrote:
> Add device tree support for the I2C and SPI variant of AD7879(-1).
> This allows to specify the touchscreen controller as a I2C client
> node or SPI slave device. Most of the options available in platform
> data are also available as device tree properties, the only exception
> being GPIO capabilities, which can not be activated through device
> tree currently.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
> Changes since v1:
> - Move device tree parsing to main driver file ad7879.c
> - Use common touchscreen_parse_properties for common properties
> - Use device_property_* API
> - Use struct ad7879 directly to store parsed values
> - Support SPI variant through device tree too (untested)
> - Add vendor prefix to vendor specific dt properties
> 
>  .../bindings/input/touchscreen/ad7879.txt          |  53 ++++++++

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/input/touchscreen/ad7879-i2c.c             |  10 ++
>  drivers/input/touchscreen/ad7879-spi.c             |  10 ++
>  drivers/input/touchscreen/ad7879.c                 | 141 +++++++++++++--------
>  4 files changed, 160 insertions(+), 54 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ad7879.txt